Code smell.

This commit is contained in:
Ivor Barhansky
2022-12-17 01:20:43 +02:00
parent b1f578f4b0
commit 0398425205
45 changed files with 875 additions and 851 deletions
+15 -15
View File
@@ -12,9 +12,9 @@ class Shop
public int $categoryType = 0;
private int $shopId;
private function __construct($shop_id)
private function __construct($shopId)
{
$this->shopId = $shop_id;
$this->shopId = $shopId;
}
public static function id($shopid): self
@@ -70,18 +70,18 @@ class Shop
public function getCategoryName(): string
{
$names = [
Item::ITEM_TYPE_HELMET => 'Шлемы',
Item::ITEM_TYPE_ARMOR => 'Броня',
Item::ITEM_TYPE_LEGS => 'Поножи',
Item::ITEM_TYPE_BOOTS => 'Сапоги',
Item::ITEM_TYPE_GLOVES => 'Перчатки',
Item::ITEM_TYPE_WEAPON => 'Оружие',
Item::ITEM_TYPE_SHIELD => 'Щиты',
Item::ITEM_TYPE_BELT => 'Пояса',
Item::ITEM_TYPE_RING => 'Кольца',
Item::ITEM_TYPE_AMULET => 'Амулеты',
Item::ITEM_TYPE_CONSUMABLE => 'Расходники',
Item::ITEM_TYPE_OTHER => 'Разное',
Item::TYPE_HELMET => 'Шлемы',
Item::TYPE_ARMOR => 'Броня',
Item::TYPE_LEGS => 'Поножи',
Item::TYPE_BOOTS => 'Сапоги',
Item::TYPE_GLOVES => 'Перчатки',
Item::TYPE_WEAPON => 'Оружие',
Item::TYPE_SHIELD => 'Щиты',
Item::TYPE_BELT => 'Пояса',
Item::TYPE_RING => 'Кольца',
Item::TYPE_AMULET => 'Амулеты',
Item::TYPE_CONSUMABLE => 'Расходники',
Item::TYPE_OTHER => 'Разное',
self::CATEGORY_SALE_ITEMS => 'Предметы в инвентаре',
0 => 'Все товары',
];
@@ -92,4 +92,4 @@ class Shop
{
return $this->categoryType !== self::CATEGORY_SALE_ITEMS || $this->categoryType !== self::BARTER_SHOP ? $this->showGoods() : $this->showUserSellItems();
}
}
}