lopar/battles
0
0
Fork 0
Code Issues 21 Pull Requests Releases Wiki Activity

Обработка ошибок. Меньше sql-запросов в логике.

Browse Source
This commit is contained in:
Igor Barkov (iwork)
2020-09-25 19:27:11 +03:00
parent 5b78d00f19
commit 3ca33f38aa
3 changed files with 94 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

138
classes/Bank.php
View File

@@ -8,11 +8,11 @@
class Bank
{
public $user_id;
public $money = 0;
public $status = '';
public $money;
private $user;
public const BANK_COMISSION = 0.05; //5%
const SUCCESS = "Успешная операция!";
const ERROR_NO_MONEY_IN_WALLET = "Ошибка! Нет денег в кошельке!";
const ERROR_NO_BANK_ACCOUNT = "Ошибка! Счёта не существует!";
const ERROR_NO_MONEY_IN_BANK_ACCOUNT = "Ошибка! Нет денег на счету!";
@@ -25,6 +25,7 @@ class Bank
public function __construct($row)
{
$bank_row = db::c()->query('SELECT user_id, money FROM bank WHERE user_id = ?i', $row)->fetch_assoc();
$this->user = db::c()->query('SELECT money FROM users WHERE id = ?i', $row)->fetch_object();
foreach ($this as $key => $value) {
if (isset($bank_row[$key])) {
$this->$key = $bank_row[$key];
@@ -39,7 +40,9 @@ class Bank
/**
* Комиссия: self::BANK_COMISSION от переводимой суммы, но не менее 1 кр.
*
* @param $amount
*
* @return int
*/
private function bankComission($amount)
@@ -54,9 +57,11 @@ class Bank
/**
* Пишем банковское событие в лог в БД
*
* @param $receiverId - user_id получателя
* @param $amount
* @param $operationType
*
* @throws \Krugozor\Database\Mysql\Exception
*/
private function bankLogs($receiverId, $amount, $operationType)
@@ -79,84 +84,93 @@ class Bank
/**
* Перевод денег между бансковскими счетами игроков с банковской комиссией.
* @param $receiver - получатель
* @param $amount - сумма
* @return string
*
* @param int $receiver
* @param int $amount
*
* @return void
* @throws \Krugozor\Database\Mysql\Exception
*/
public function sendMoney($receiver, $amount)
public function sendMoney(int $receiver, int $amount): void
{
if ($amount > 0) {
if (db::c()->query('SELECT `user_id` FROM `bank` WHERE `id` = ?i', $receiver)) {
$amountWithComission = $amount + $this->bankComission($amount);
if ($amountWithComission <= $this->money) {
// Снимаем сумму с комиссией у отправителя
db::c()->query('UPDATE bank SET money = money - ?i WHERE `user_id` = ?i', $amountWithComission, $this->user_id);
// Отдаём сумму на счёт получателю
db::c()->query('UPDATE bank SET money = money + ?i WHERE `user_id` = ?i', $amount, $receiver);
$this->bankLogs($receiver,$amount,"sendMoney");
$this->status = self::SUCCESS;
} else {
$this->status = self::ERROR_NO_MONEY_IN_BANK_ACCOUNT;
}
} else {
$this->status = self::ERROR_NO_BANK_ACCOUNT;
}
} else {
$this->status = self::ERROR_WRONG_AMOUNT;
if ($amount <= 0) {
throw new Exception(self::ERROR_WRONG_AMOUNT);
}
return $this->status;
if (!db::c()->query('SELECT 1 FROM bank WHERE user_id = ?i', $receiver)) {
throw new Exception(self::ERROR_NO_BANK_ACCOUNT);
}
$amountWithComission = $amount + $this->bankComission($amount);
if ($amountWithComission > $this->money) {
throw new Exception(self::ERROR_NO_MONEY_IN_BANK_ACCOUNT);
}
$this->money -= $amountWithComission;
// Снимаем сумму с комиссией у отправителя
$this->setBankMoney($this->money, $this->user_id);
// Отдаём сумму на счёт получателю
$this->setBankMoney($amount, $receiver);
$this->bankLogs($receiver, $amount, "sendMoney");
}
/**
* Пополнение банковского счёта игрока
* @param $amount - сумма
* @return string
*
* @param int $amount - сумма
*
* @return void
* @throws \Krugozor\Database\Mysql\Exception
*/
public function depositMoney($amount)
public function depositMoney(int $amount): void
{
if ($amount > 0) {
$row = db::c()->query('SELECT money FROM users WHERE id = ?i', $this->user_id)->fetch_assoc();
if ($amount >= $row['money']) {
// Забираем деньги из кошелька получателя
db::c()->query('UPDATE users SET money = money - ?i WHERE `id` = ?i', $amount, $this->user_id);
// Отдаём сумму на счёт получателю
db::c()->query('UPDATE bank SET money = money + ?i WHERE `user_id` = ?i', $amount, $this->user_id);
$this->bankLogs(0, $amount, "depositMoney");
$this->status = self::SUCCESS;
} else {
$this->status = self::ERROR_NO_MONEY_IN_WALLET;
}
} else {
$this->status = self::ERROR_WRONG_AMOUNT;
if ($amount <= 0) {
throw new Exception(self::ERROR_WRONG_AMOUNT);
}
return $this->status;
$wallet = db::c()->query('SELECT money FROM users WHERE id = ?i', $this->user_id)->fetch_object();
if ($wallet->money < $amount) {
throw new Exception(self::ERROR_NO_MONEY_IN_WALLET);
}
// Забираем деньги из кошелька получателя
//todo check it!
$this->user->money -= $amount;
$this->setWalletMoney($this->user->money, $this->user_id);
// Отдаём сумму на счёт получателю
$this->money += $amount;
$this->setBankMoney($this->money, $this->user_id);
$this->bankLogs(0, $amount, "depositMoney");
}
/**
* Снятие денег с банковского счёта игрока с банковской комиссией.
* @param $amount - сумма
* @return string
*
* @param int $amount - сумма
*
* @return void
* @throws \Krugozor\Database\Mysql\Exception
*/
public function withdrawMoney($amount)
public function withdrawMoney(int $amount): void
{
if ($amount > 0) {
$amountWithComission = $amount + $this->bankComission($amount);
if ($amountWithComission <= $this->money) {
// Снимаем сумму с комиссией у отправителя
db::c()->query('UPDATE bank SET money = money - ?i WHERE `user_id` = ?i', $amountWithComission, $this->user_id);
// Отдаём сумму в кошелёк получателя
db::c()->query('UPDATE users SET money = money + ?i WHERE `id` = ?i', $amount, $this->user_id);
$this->bankLogs(0, $amount, "withdrawMoney");
$this->status = self::SUCCESS;
} else {
$this->status = self::ERROR_NO_MONEY_IN_BANK_ACCOUNT;
}
} else {
$this->status = self::ERROR_WRONG_AMOUNT;
if ($amount <= 0) {
throw new Exception(self::ERROR_WRONG_AMOUNT);
}
return $this->status;
$amountWithComission = $amount + $this->bankComission($amount);
if ($this->money < $amountWithComission) {
throw new Exception(self::ERROR_NO_MONEY_IN_BANK_ACCOUNT);
}
// Снимаем сумму с комиссией у отправителя
$this->money -= $amountWithComission;
$this->setBankMoney($this->money, $this->user_id);
// Отдаём сумму в кошелёк получателя
//todo check it!
$this->user->money += $amount;
$this->setWalletMoney($this->user->money, $this->user_id);
$this->bankLogs(0, $amount, "withdrawMoney");
}
private function setBankMoney(int $amount, int $user_id): void
{
db::c()->query('UPDATE bank SET money = ?i WHERE `id` = ?i', $amount, $user_id);
}
private function setWalletMoney(int $amount, int $user_id): void
{
db::c()->query('UPDATE users SET money = ?i WHERE `id` = ?i', $amount, $user_id);
}
}