Code smell

This commit is contained in:
Igor Barkov (iwork) 2020-07-03 17:14:08 +03:00
parent dcc5a2b482
commit a394c61be0

77
inf.php
View File

@ -8,7 +8,19 @@ $uid = $_SESSION['uid'] ?? null;
// FROM `users` // FROM `users`
// WHERE `login` = "?s" OR `id` = "?s"', $login, $login)->fetch_assoc(); // WHERE `login` = "?s" OR `id` = "?s"', $login, $login)->fetch_assoc();
$user = new User($_SESSION['uid']); $user = new User($_SESSION['uid']);
$own = db::c()->query('SELECT `align`,`admin` FROM `users` WHERE `id` = "?s"', $uid)->fetch_assoc(); const MODERATOR_ACCESS = 1;
const ADMINISTRATOR_ACCESS = 2;
function private_access($uid)
{
$own = db::c()->query('SELECT `align`,`admin` FROM `users` WHERE `id` = "?s"', $uid)->fetch_assoc();
if ($own['admin'] === 1) {
return ADMINISTRATOR_ACCESS;
} elseif ($own['align'] === 1) {
return MODERATOR_ACCESS;
}
return false;
}
//$presents = db::c()->query('SELECT img, sender FROM `users_presents` WHERE expiration_date >= "?s" AND owner = ?i', date('Y-m-d'), $user->id); //$presents = db::c()->query('SELECT img, sender FROM `users_presents` WHERE expiration_date >= "?s" AND owner = ?i', date('Y-m-d'), $user->id);
$presents = []; $presents = [];
@ -33,19 +45,22 @@ if (empty($user->id)): ?>
<link href="css/main.css" rel="stylesheet"> <link href="css/main.css" rel="stylesheet">
</head> </head>
<body> <body>
<?php if ($user->admin === 1 && $own['admin'] != 1 && file_exists('customuserdata/' . $user['id'])) {die(file_get_contents('customuserdata/' . $user['id']));} ?> <?php if ($user->admin === 1 && private_access($uid) !== ADMINISTRATOR_ACCESS && file_exists('customuserdata/' . $user['id'])) {
die(file_get_contents('customuserdata/' . $user['id']));
} ?>
<table width=100%> <table width=100%>
<tr> <tr>
<td style="width: 250px; vertical-align: top;"> <td style="width: 250px; vertical-align: top;">
<?= showinf_pers($user['id']); <?php /*echo showinf_pers($user['id']);*/
if (!empty($user->married)): ?> if (!empty($user->married)): ?>
<a href="inf.php?<?= $user->married ?>" target=_blank> <a href="inf.php?<?= $user->married ?>" target=_blank>
<img alt="В браке с <?= $user->married ?>" src="i/married.gif" title="В браке с <?= $user->married ?>"> <img alt="В браке с <?= $user->married ?>" src="i/married.gif"
title="В браке с <?= $user->married ?>">
</a> </a>
<?php endif; ?> <?php endif; ?>
</td> </td>
<td style="vertical-align: top; width: 100px; text-align: center;"> <td style="vertical-align: top; width: 100px; text-align: center;">
<img src="i/zodiac/<?= star_sign(substr($user->borndate, 3, 2), substr($user->borndate, 0, 2)); ?>.png"> <img src="i/zodiac/<?= star_sign(substr($user->borndate, 3, 2), substr($user->borndate, 0, 2)); ?>.png" alt="Родовой знак">
</td> </td>
</tr> </tr>
</table> </table>
@ -53,8 +68,12 @@ if (empty($user->id)): ?>
<!-- Нижняя часть --> <!-- Нижняя часть -->
<?php <?php
$effect = db::c()->query('SELECT `time` FROM `effects` WHERE `owner` = ?i AND `type` = ?i ', $user->id, 5)->fetch_assoc(); $effect = db::c()->query('SELECT `time` FROM `effects` WHERE `owner` = ?i AND `type` = ?i ', $user->id, 5)->fetch_assoc();
if ($effect['time'] && ($own['admin'] != 1)) {die('<h3>Персонаж обезличен!</h3>');} if ($effect['time'] && !private_access($uid)) {
if (!empty($user->realname)) {echo "Имя: " . $user->realname . "<br>";} die('<h3>Персонаж обезличен!</h3>');
}
if (!empty($user->realname)) {
echo "Имя: " . $user->realname . "<br>";
}
?> ?>
<p style="font-family: Consolas,monospace;"><?= nl2br($user->info) ?></p> <p style="font-family: Consolas,monospace;"><?= nl2br($user->info) ?></p>
<hr> <hr>
@ -70,12 +89,8 @@ if (!empty($user->realname)) {echo "Имя: " . $user->realname . "<br>";}
<?php <?php
# Секретный раздел # Секретный раздел
$showModeratorInfo = false;
# Если я любой паладин, и смотрю не админа, или я сам админ. # Если я любой паладин, и смотрю не админа, или я сам админ.
if ((($own['align'] == 1) && (!$user->admin)) || (!empty($own['admin']))) {$showModeratorInfo = true;} if ((private_access($uid) === MODERATOR_ACCESS && !$user->admin) || private_access($uid) === ADMINISTRATOR_ACCESS) {
if ($showModeratorInfo == 1) {
//$ld = db::c()->query('SELECT * FROM `lichka` WHERE `pers` = ?i ORDER BY `id` ASC', $user['id']); //$ld = db::c()->query('SELECT * FROM `lichka` WHERE `pers` = ?i ORDER BY `id` ASC', $user['id']);
$ld = db::c()->query(); $ld = db::c()->query();
echo "<H4>Личное дело</H4>"; echo "<H4>Личное дело</H4>";
@ -85,22 +100,38 @@ if ($showModeratorInfo == 1) {
} }
echo "<H4>Дополнительные сведения</H4>"; echo "<H4>Дополнительные сведения</H4>";
if (!empty($user->id)) {echo "ID: " . $user->id . "<br>";} if (!empty($user->id)) {
if (!empty($user->email)) {echo "E-mail: " . $user->email . "<br>";} echo "ID: " . $user->id . "<br>";
if (!empty($user->borndate)) {echo "День рождения: " . $user->borndate . "<br>";} }
if (!empty($user->ip)) {echo "IP при регистрации: " . $user->ip . "<br>";} if (!empty($user->email)) {
echo "E-mail: " . $user->email . "<br>";
}
if (!empty($user->borndate)) {
echo "День рождения: " . $user->borndate . "<br>";
}
if (!empty($user->ip)) {
echo "IP при регистрации: " . $user->ip . "<br>";
}
} }
if ($own['admin'] == 1) { if (private_access($uid) === ADMINISTRATOR_ACCESS) {
if (!empty($user->exp)) {echo "Oпыт: " . $user->exp . "<br>";} if (!empty($user->exp)) {
if (!empty($user->stats)) {echo "Число неиспользованных UP-ов: " . $user->stats . "<br>";} echo "Oпыт: " . $user->exp . "<br>";
if (!empty($user->money)) {echo "Кредитов: " . $user->money . "<br>";} }
if (!empty($user->room)) {echo "Комната: " . $user->room . "<br>";} if (!empty($user->stats)) {
echo "Число неиспользованных UP-ов: " . $user->stats . "<br>";
}
if (!empty($user->money)) {
echo "Кредитов: " . $user->money . "<br>";
}
if (!empty($user->room)) {
echo "Комната: " . $user->room . "<br>";
}
echo "<H4>Банковские счета</H4>"; echo "<H4>Банковские счета</H4>";
$bankInfo = new Bank($user->id); $bankInfo = new Bank($user->id);
echo "Счет: " . $bankInfo->user_id.PHP_EOL; echo "Счет: " . $bankInfo->user_id . PHP_EOL;
echo "Деньги на счету: " . $bankInfo->money.PHP_EOL; echo "Деньги на счету: " . $bankInfo->money . PHP_EOL;
} }
?> ?>