From 4c8cabe8aed2123f9f2f99e3fe209f69a17a7e9b Mon Sep 17 00:00:00 2001 From: MrDoritos Date: Tue, 8 Oct 2019 19:52:03 -0600 Subject: [PATCH 1/2] [MKV Thumbnail Support] MKV Thumbnails with FFMpeg --- youtube_dl/postprocessor/embedthumbnail.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/youtube_dl/postprocessor/embedthumbnail.py b/youtube_dl/postprocessor/embedthumbnail.py index 56be914b8..acb7958c9 100644 --- a/youtube_dl/postprocessor/embedthumbnail.py +++ b/youtube_dl/postprocessor/embedthumbnail.py @@ -50,6 +50,19 @@ class EmbedThumbnailPP(FFmpegPostProcessor): self.run_ffmpeg_multiple_files([filename, thumbnail_filename], temp_filename, options) + if not self._already_have_thumbnail: + os.remove(encodeFilename(thumbnail_filename)) + os.remove(encodeFilename(filename)) + os.rename(encodeFilename(temp_filename), encodeFilename(filename)) + + if info['ext'] == 'mkv': + options = [ + '-c', 'copy', '-attach', thumbnail_filename, '-metadata:s:t', 'mimetype=image/jpeg'] + + self._downloader.to_screen('[ffmpeg] Adding thumbnail to "%s"' % filename) + + self.run_ffmpeg_multiple_files([filename], temp_filename, options) + if not self._already_have_thumbnail: os.remove(encodeFilename(thumbnail_filename)) os.remove(encodeFilename(filename)) From a0b2ee64dbe6d4bedad9883cc8014aa77cdd0138 Mon Sep 17 00:00:00 2001 From: MrDoritos Date: Tue, 8 Oct 2019 20:02:45 -0600 Subject: [PATCH 2/2] [MKV Thumbnail Support] Changed from Tabs to spaces --- youtube_dl/postprocessor/embedthumbnail.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/youtube_dl/postprocessor/embedthumbnail.py b/youtube_dl/postprocessor/embedthumbnail.py index acb7958c9..eae266dde 100644 --- a/youtube_dl/postprocessor/embedthumbnail.py +++ b/youtube_dl/postprocessor/embedthumbnail.py @@ -55,10 +55,10 @@ class EmbedThumbnailPP(FFmpegPostProcessor): os.remove(encodeFilename(filename)) os.rename(encodeFilename(temp_filename), encodeFilename(filename)) - if info['ext'] == 'mkv': - options = [ - '-c', 'copy', '-attach', thumbnail_filename, '-metadata:s:t', 'mimetype=image/jpeg'] - + if info['ext'] == 'mkv': + options = [ + '-c', 'copy', '-attach', thumbnail_filename, '-metadata:s:t', 'mimetype=image/jpeg'] + self._downloader.to_screen('[ffmpeg] Adding thumbnail to "%s"' % filename) self.run_ffmpeg_multiple_files([filename], temp_filename, options)