1
0
mirror of https://github.com/ytdl-org/youtube-dl.git synced 2024-12-22 07:56:49 +00:00

[postprocessor/ffmpeg] Allow options for mp3

Why?
Options like `preferredquality` are ignored when postprocessing mp3s.

What?
Remove `mp3` from the list of `filecodec` values to check for in the
"lossless" condition unless `preferredquality` is unspecified.
This commit is contained in:
Alex Richards 2023-08-15 13:15:42 -07:00
parent 86e3cf5e58
commit e8bebe0b03

View File

@ -284,7 +284,10 @@ class FFmpegExtractAudioPP(FFmpegPostProcessor):
acodec = 'copy'
extension = 'm4a'
more_opts = ['-bsf:a', 'aac_adtstoasc']
elif filecodec in ['aac', 'flac', 'mp3', 'vorbis', 'opus']:
elif (
filecodec in ['aac', 'flac', 'vorbis', 'opus'] or
(filecodec == 'mp3' and self._preferredquality is None)
):
# Lossless if possible
acodec = 'copy'
extension = filecodec